Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sailor): returns the correct 404 status for custom pages. #150

Merged
merged 2 commits into from
Jul 20, 2017
Merged

fix(sailor): returns the correct 404 status for custom pages. #150

merged 2 commits into from
Jul 20, 2017

Conversation

soapdog
Copy link
Contributor

@soapdog soapdog commented Jun 20, 2017

This pull request changes the status code returned by custom 404 pages to the correct one, solves #137

@coveralls
Copy link

coveralls commented Jun 20, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 82.589% when pulling bca09fb on soapdog:master into 2aa1026 on sailorproject:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 82.589% when pulling bca09fb on soapdog:master into 2aa1026 on sailorproject:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 82.589% when pulling bca09fb on soapdog:master into 2aa1026 on sailorproject:master.

@coveralls
Copy link

coveralls commented Jun 21, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 82.666% when pulling a3fe7a8 on soapdog:master into 2aa1026 on sailorproject:master.

Etiene
Etiene approved these changes Jul 20, 2017
View reviewed changes
Copy link
Member

@Etiene Etiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 💖

@Etiene Etiene merged commit 9657d5a into sailorproject:master Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Etiene Etiene Etiene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soapdog @coveralls @Etiene